Skip to content

Synchronize ASMHelpers.copyMethodNode #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VortexSo4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Synchronize ASMHelpers.copyMethodNode #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/scala/li/cil/oc/common/asm/ASMHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public static void dumpClass(String className, byte[] originalBytes, byte[] tran
}
}

public static MethodNode copyMethodNode(MethodNode methodNode) {
public static synchronized MethodNode copyMethodNode(MethodNode methodNode) {

@Nikolay-Sitnikov Nikolay-Sitnikov Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This doesn't access any state shared between threads. (unless you mean the MethodNode, in which case I think it's still safe, since this method doesn't mutate the shared MethodNode), which makes it safe to use between threads (as long as no other threads access the MethodNode before the MethodNode is finalized.)

MethodNode newMethodNode = new MethodNode(
methodNode.access, methodNode.name, methodNode.desc, methodNode.signature,
methodNode.exceptions == null ? null : methodNode.exceptions.toArray(new String[0])
Expand Down