Skip to content

Fix TiC/GT cross-hand tool durability and off-hand tool selection#12

Merged
tier940 merged 2 commits intomasterfrom
tier-tic-tools
Apr 13, 2026
Merged

Fix TiC/GT cross-hand tool durability and off-hand tool selection#12
tier940 merged 2 commits intomasterfrom
tier-tic-tools

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 13, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 13, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the integration between Tinkers' Construct (TiC) and GregTech (GT) by refining how cross-hand tool combinations function. It fixes issues where the off-hand tool was not correctly utilized for block harvesting and resolves bugs causing duplicate durability loss. Additionally, it introduces a robust system to maintain dynamic material name translations across resource reloads.

Highlights

  • TiC/GT Cross-Hand Tool Logic: Refactored the cross-hand tool interaction logic to correctly prioritize the off-hand tool when it is the appropriate tool for the block, preventing incorrect durability loss.
  • Dynamic Translation Persistence: Implemented a caching mechanism for dynamic material name translations to ensure they persist after resource reloads (e.g., F3+T or language changes).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストでは、Tinkers' ConstructとGregTechのツール統合における持ち手(メインハンド/オフハンド)の判定ロジックの修正、重複する耐久値減少の解消、およびリソースリロード後の動的な素材名翻訳の再注入機能が追加されました。レビューでは、TiCModule 内でクライアント専用イベントを使用しているためサーバー側でクラッシュする可能性がある点と、ツールを必須としないブロック(土など)に対してオフハンドのツールが適切に選択されないロジックの改善が指摘されています。

Comment thread src/main/java/com/github/gtexpert/gtmt/integration/tic/TiCModule.java Outdated
@tier940 tier940 merged commit ee19ee9 into master Apr 13, 2026
2 checks passed
@tier940 tier940 deleted the tier-tic-tools branch April 13, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant