Skip to content

Add storage drawers integration#10

Merged
tier940 merged 23 commits intomasterfrom
kono/addStorageDrawersIntegration
Apr 11, 2026
Merged

Add storage drawers integration#10
tier940 merged 23 commits intomasterfrom
kono/addStorageDrawersIntegration

Conversation

@MrKono
Copy link
Copy Markdown
Member

@MrKono MrKono commented Apr 10, 2026

  • GT materials can now be used to craft Storage Upgrades.
  • Craftable materials, multipliers, and related settings can be configured via cfg.
  • Original materials (Obsidian/Iron/Gold/Diamond/Emerald) are always included.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new integration module for the Storage Drawers mod, allowing players to craft storage upgrades using various GregTech materials. The change provides a flexible configuration system for defining these new upgrades, including their capacity multipliers and required field generator tiers, while also offering options to replace default progression. The implementation includes new items, recipes, and mixins to ensure seamless functionality within the existing storage system.

Highlights

  • Storage Upgrades Integration: Added support for crafting Storage Upgrades using GregTech materials, with configurable multipliers and tier requirements.
  • Configuration Options: Introduced new configuration settings to define custom materials for upgrades and control whether original Storage Upgrade recipes are removed.
  • Mixin Implementation: Implemented necessary mixins to integrate custom storage upgrade logic into the Storage Drawers mod functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、Storage Drawersとの連携機能を追加し、GregTechの素材を用いたストレージアップグレードの製作を可能にします。コンフィグにより倍率や必要ティアを柔軟に設定でき、Mixinを用いてStorage Drawersの容量計算ロジックに統合されています。フィードバックでは、マテリアルフラグ設定時のバリデーション不備や、ティア解析時の境界値チェックミスによる例外発生リスクの修正、およびドキュメントやコード内のタイポ修正を求めています。

Comment thread DEVELOPER.md Outdated
@MrKono MrKono requested a review from tier940 April 10, 2026 14:49
@tier940 tier940 merged commit 1b5bf48 into master Apr 11, 2026
2 checks passed
@tier940 tier940 deleted the kono/addStorageDrawersIntegration branch April 11, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants