Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally found what was mismatching and fixed
Layer::getDefaultLayers, yay!I changed
LevelData::getBiomeScale()to return anunsigned charinstead of aboolto matchBiomeSource::LayerOverrideSettings::GetBiomeScale(), and that removed an extra instruction. I also changedBiomeInitLayerto takebiomeinstead oflayerand cleaned up howuseBiomeScaleis copied into anintforZoomLayer::zoomto fix extension and register reuse issues, and i also removed theNON_MATCHINGcomment this time.tools/checkstill says OK and it updated the function in the CSV to MatchingThat took me so long to figure out ._.
Also tell me if i need to change anything, in case i might have forgot again
@GRAnimated