Skip to content

Fix Layer::getDefaultLayers mismatch - #127

Open
SSMG64 wants to merge 1 commit into
GRAnimated:mainfrom
SSMG64:fix-layer-getdefaultlayers-mismatch
Open

SSMG64 wants to merge 1 commit into
GRAnimated:mainfrom
SSMG64:fix-layer-getdefaultlayers-mismatch

Conversation

@SSMG64

@SSMG64 SSMG64 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

I finally found what was mismatching and fixed Layer::getDefaultLayers, yay!

I changed LevelData::getBiomeScale() to return an unsigned char instead of a bool to match BiomeSource::LayerOverrideSettings::GetBiomeScale(), and that removed an extra instruction. I also changed BiomeInitLayer to take biome instead of layer and cleaned up how useBiomeScale is copied into an int for ZoomLayer::zoom to fix extension and register reuse issues, and i also removed the NON_MATCHING comment this time.

tools/check still says OK and it updated the function in the CSV to Matching

That took me so long to figure out ._.
Also tell me if i need to change anything, in case i might have forgot again

@GRAnimated

@DexrnZacAttack DexrnZacAttack self-assigned this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants