Skip to content

Reconstruct NBT, streams and core helpers - #116

Closed
cube-one-ber wants to merge 3 commits into
GRAnimated:mainfrom
cube-one-ber:reconstruct-serialization-core
Closed

cube-one-ber wants to merge 3 commits into
GRAnimated:mainfrom
cube-one-ber:reconstruct-serialization-core

Conversation

@cube-one-ber

Copy link
Copy Markdown

Adds the missing NBT and stream routines, data-fixer helpers, and core math/geometry helpers.

  • CompoundTag, ListTag, numeric tags, compressed NBT and stream protocol helpers.
  • DataFixerUpper, data walkers, block positions, vector helpers and AABB clipping.

Includes the shared Switch declarations and caller fixes needed by these routines. Updates the corresponding function annotations and shared symbol names.

Switch build, tools/check, tools/lint.py --slow and clang-format 20.1.8 pass. 231 more matching entries; implemented mismatches remain marked M.

@DexrnZacAttack

Copy link
Copy Markdown
Collaborator

too many changes that I don't have time to review but whatever wrote this pr (if even human) is making the codebase messy imo

@DexrnZacAttack

Copy link
Copy Markdown
Collaborator

basically (assuming a human wrote most of this and not some super slopbot): dont make random typedefs, use pure cpp types for most part
(unless we all agree to start using our own typedefs for u{bits},s{bits} in future)
dont split source files for basically any reason
use doxygen comments
and idk the robotic slop comments suck dont make those
make sure all symbols you are creating exist in-game (if not, mention that it is an custom helper, but these shouldn't really be made anyways, if anything is required for the most part just use a define), or if existent in Wii U but not switch then name guessing is fine, just mention that the name is guessed with a small comment like // name guessed

anything that is guessed really should be mentioned in a small comment unless its already 100% obvious that the return type is correct

dont pull code,names,references, or anything from the LCE leak (!!!!)

if non-matching, leave comment: // NON_MATCHING | score: {score} (lower is better)

@cube-one-ber

Copy link
Copy Markdown
Author

ok

@DexrnZacAttack

Copy link
Copy Markdown
Collaborator

just checking, you're actually doing like most of the decomp work... right???

@DexrnZacAttack

Copy link
Copy Markdown
Collaborator

I don't like it when its just someone giving army of agents task to decomp the code and then that takes away from all of the actual fun for everyone else

but when I look at everything again im like 99% sure its entirely slopbot

@cube-one-ber cube-one-ber closed this by deleting the head repository Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants