Reformat GEOS_IrradGridComp.F90: consistent indentation and RC-macro style - #99
Merged
Merged
Conversation
…style Purely mechanical formatting pass over the original (MAPL2) source, no functional changes. - Reindent all code to a consistent 3-space block indent. Use a flat 5-space continuation-line indent throughout. - Strip purely decorative dash-only/equals-only comment dividers - Collapse `RC=STATUS` / `VERIFY_(STATUS)` pairs - two-line, same-line (`; VERIFY_(STATUS)`), and extra-whitespace (`RC=STATUS )`) forms - into the single-line `_RC` macro. Pairs that can't be safely collapsed (if-condition usage, NotFoundOK calls, dynamic RATS pointers explicitly marked "Don't verify.", multi-branch calls sharing one trailing VERIFY_ after an if/elseif chain) are left as RC=STATUS/VERIFY_(STATUS). - Rename `__RC__` -> `_RC` and `__STAT__` -> `_STAT` throughout. 4574 -> 4425 lines.
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
pchakraborty
added
the
0 diff trivial
tclune
approved these changes
Aug 17, 2026
This was referenced Aug 19, 2026
Member
|
@narnold1 Would you mind being added to @GEOS-ESM/radiation-team ? I mean, since Peter left, you might be our expert in this! |
mathomp4
approved these changes
Sep 3, 2026
pchakraborty
deleted the
refactor/pchakrab/reindent-acgfy-restructure
branch
September 3, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purely mechanical formatting pass over the original (MAPL2) source, no functional changes.
RC=STATUS/VERIFY_(STATUS)pairs - two-line, same-line (; VERIFY_(STATUS)), and extra-whitespace (RC=STATUS )) forms - into the single-line_RCmacro. Pairs that can't be safely collapsed (if-condition usage, NotFoundOK calls, dynamic RATS pointers explicitly marked "Don't verify.", multi-branch calls sharing one trailing VERIFY_ after an if/elseif chain) are left as RC=STATUS/VERIFY_(STATUS).__RC__->_RCand__STAT__->_STATthroughout.4574 -> 4425 lines.