Fixes #1482: spurious source of water - #1483
Open
narnold1 wants to merge 5 commits into
Open
Conversation
…orrect negative QL/QI.
narnold1
added
Non 0-diff
Member
|
Not sure if this is what it was intended for, but with this PR, I can now run in Debug (see #1466 ) ETA: Well, with Intel. I'll try GNU now. ETA2: Apparently GNU is working without this. I'll try ifx. ETA3: Never mind. ifx failed. It might have just been coincidence with ifort. Dang! |
Contributor
Author
|
Spurious water from GF was traced to two errors: (1) excessive precip evaporation, leading to negative surface precip, and (2) vertical smoothing of the final GF tendencies. A fix for the excessive evaporation was added to the branch. The smoothing can be disabled by setting USE_SMOOTH_TEND: 0, but this needs further testing. |
narnold1
marked this pull request as ready for review
August 31, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This initial commit fixes the spurious water from UW by simply allowing the SUB and ENT tendencies to create negative condensate, which is then "filled" by the FILLQ2ZERO routines immediately after.
Alternately we could modify the SUB and ENT tendencies as needed to prevent negative condensate, but would then need to modify QV to conserve the total water.