Skip to content

Fixing macOS build#4052

Merged
rrsettgast merged 2 commits intodevelopfrom
bugfix/castelletto1/macOS
May 9, 2026
Merged

Fixing macOS build#4052
rrsettgast merged 2 commits intodevelopfrom
bugfix/castelletto1/macOS

Conversation

@castelletto1
Copy link
Copy Markdown
Collaborator

@castelletto1 castelletto1 commented May 8, 2026 •
edited
Loading

  • replace dynamic_cast with hasWrapper in PhysicsSolverBase::gravityVector to break
    libphysicsSolversBase -- libphysicsSolvers typeinfo cycle (tolerated in Linux not in macOS)
  • declare physicsSolversBase as fluidFlow dependency (was silently inherited)
  • add surfaceGeneration to multiphysics dependency list (used by
    HydrofractureSolver)
  • explicit template instantiation for Damage<ElasticIsotropic>

Updated PVTPackage submodule: GEOS-DEV/PVTPackage/pull/54

@castelletto1 castelletto1 self-assigned this May 8, 2026
@castelletto1 castelletto1 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires updated submodule(s) ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels May 8, 2026
@rrsettgast rrsettgast merged commit 4bb0217 into develop May 9, 2026
21 checks passed
@rrsettgast rrsettgast deleted the bugfix/castelletto1/macOS branch May 9, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrsettgast rrsettgast rrsettgast approved these changes

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

Assignees

@castelletto1 castelletto1

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: requires updated submodule(s)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@castelletto1 @rrsettgast