chore: updates to support new CSS - #1
Open
mcoker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I added CSS support for the backdrop and modal animations, and did so working off of this branch. Here are the changes I made to get it working. Some helpful links:
The core PR with the CSS changes: patternfly/patternfly#8584
The parent PR this PR is against: patternfly#12552
Primarily I changed the modal and backdrop back to conditionally rendering, since I'm not sure if always rendering them in the DOM might create some sort of z-index/stacking order issues.
One question is about the backdrop component. Backdrop doesn't have the equivalent of modal's
isOpen, so we/users must be dynamically rendering the component, which means everyone will need to hook into thetransitionEndevent (or set a manualsetTimeout()or whatever) to allow the backdrop's hide/close animation to finish before unmounting. I wonder if it should have something like that? Not as a part of this feature, but in the future to make the backdrop more flexible.