Skip to content

Moving the project to a pyproject.toml file - #553

Merged
jgrewe merged 13 commits into
G-Node:masterfrom
wendtalexander:pyproject
Sep 18, 2026
Merged

jgrewe merged 13 commits into
G-Node:masterfrom
wendtalexander:pyproject

Conversation

@wendtalexander

Copy link
Copy Markdown
Contributor

I don't know how to test this properly it works on my machine simply with

pip install .

in the project directory.

you can now specify which dependencies you want to install. If you want all dependencies for testing and building the docs you can install them with this command

pip install ".[all]"

@wendtalexander

Copy link
Copy Markdown
Contributor Author

With the pyproject.toml file the setup.py file is obsolete and I removed it, but appveyor, and the github actions expecting a setup.py, and I dont know how to fix these things.

Maybe we can replace this with

python -m build . 

or

pip install ".[all]"

And maybe can we drop support for python 3.8, because its end of life, and the setuptools required for python3.8 does not support the license-files key in the pyproject.toml file, which is now standard.

@wendtalexander

Copy link
Copy Markdown
Contributor Author

I moved the optional-dependencies to a single [dev] key in the pyproject.toml file so we can install all dependencies with one call

pip install ".[dev]"

this can replace the

python setup.py install 

in all the GitHub actions that use this line.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 78.615% — wendtalexander:pyproject into G-Node:master. No base build found for G-Node:master.

@jgrewe jgrewe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgrewe
jgrewe merged commit 831080a into G-Node:master Sep 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants