Always set Vary response header to fix caching#4
Open
qrdl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the html2md proxy-wasm filter to ensure downstream caches correctly separate converted Markdown responses from unconverted HTML by always varying responses on the internal Convert request header.
Changes:
- Always add/merge
Vary: Convertinon_http_response_headersso caches don’t reuse the wrong representation across requests. - Split the Markdown MIME constant into request vs response values and set response
Content-Typeto includecharset=utf-8.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+70
to
+84
| if let Some(vary) = self.get_http_response_header("Vary") { | ||
| let has_convert = vary | ||
| .split(',') | ||
| .any(|v| v.trim().eq_ignore_ascii_case(CONVERT_FLAG)); | ||
| if !has_convert { | ||
| let new_vary = if vary.is_empty() { | ||
| CONVERT_FLAG.to_string() | ||
| } else { | ||
| format!("{}, {}", CONVERT_FLAG, vary) | ||
| }; | ||
| self.set_http_response_header("Vary", Some(&new_vary)); | ||
| } | ||
| } else { | ||
| self.add_http_response_header("Vary", CONVERT_FLAG); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.