vm meta manifest by TheHeroBrine422 · Pull Request #32 · FyraStack/odorobo

TheHeroBrine422 · 2026-04-28T20:21:16Z

No description provided.

Signed-off-by: Caleb Jones <caleb@calebgj.io>

isolating ch references. will move this to another crate later. Signed-off-by: Caleb Jones <caleb@calebgj.io>

Signed-off-by: Caleb Jones <caleb@calebgj.io>

TheHeroBrine422 · 2026-04-29T01:16:12Z

@korewaChino most of those are intended to be temporary. just was getting it good enough so it would boot. If I was thinking better, I would have had it where the ctl could modify those values instead of hardcoding them lol.

was intending on adding more later, but it wasnt necessary for just getting the the manifest arguably working.

korewaChino · 2026-04-29T01:17:30Z

@korewaChino most of those are intended to be temporary. just was getting it good enough so it would boot. If I was thinking better, I would have had it where the ctl could modify those values instead of hardcoding them lol.

was intending on adding more later, but it wasnt necessary for just getting the the manifest arguably working.

you can resolve those specific review comments then, mark them with a TODO or something too just in case

TheHeroBrine422 · 2026-04-29T01:19:51Z

ok cool

TheHeroBrine422 · 2026-04-29T01:21:00Z

oh forgot one thing. the operators stuff was based on the kubernetes pod affinity stuff. affinity isnt really finished though anyway, I just started writing it and then realized it is kinda integrated into the meta manifest. it arguably should be its own PR, but somehow i accidentally mixed it in.

Signed-off-by: Caleb Jones <caleb@calebgj.io>

TheHeroBrine422 · 2026-04-29T01:29:36Z

@korewaChino added todos, or did the review comments if they were simple. anything else, or good to merge?

korewaChino · 2026-04-29T05:38:15Z

            VMCacheData {
                actor_ref: actor_ref.clone(),
-                config: msg.config.clone()
+                config: Default::default()


empty default on cache miss?

we need to decide if the migrate messages are ch specific or used for everything. the cache is now setup to store the overall meta-manifest and the current migrate messages are ch specific. so they don't have a copy of the manfiest. we also could just get a copy from the old vm, but im not 100% sure if we want to rely on getting a copy from there.

korewaChino · 2026-04-29T05:40:45Z

+                max_vcpus: vm.data.max_vcpus.unwrap_or(vm.data.vcpus) as i32,
+                kvm_hyperv: Some(false),
+                max_phys_bits: Some(46),
+                nested: Some(false),


why disable nested kvm?

this is what the example config you gave me had it set to. I also thought it was odd, but assumed you had a good reason.

nah it was an experiment I forgot to remove, we can omit it and leave it to Default::default()

korewaChino · 2026-04-29T05:43:02Z

+                DiskConfig {
+                    // todo: the json i was given by cappy had disable_io_uring and disable_aio in this config, but I can't find these. I assume they were just a mistake.
+                    path: Some(vm.data.image),
+                    readonly: Some(false),
+                    direct: Some(false),
+                    iommu: Some(false),
+                    num_queues: Some(1),
+                    queue_size: Some(128),
+                    vhost_user: Some(false),
+                    id: Some("_disk0".to_string()),
+                    pci_segment: Some(0),
+                    backing_files: Some(false),
+                    sparse: Some(true),
+                    image_type: Some(ImageType::Raw),
+                    ..Default::default()
+                }
+            ]),


disk config should be defined by the VirtualMachine manifest with volumes as an array or something

korewaChino · 2026-04-29T05:44:56Z

+        VmConfig {
+            cpus: Some(CpusConfig {
+                boot_vcpus: vm.data.vcpus as i32,
+                max_vcpus: vm.data.max_vcpus.unwrap_or(vm.data.vcpus) as i32,
+                kvm_hyperv: Some(false),
+                max_phys_bits: Some(46),
+                nested: Some(false),
+                features: Some(CpuFeatures {
+                    amx: Some(false)
+                }),
+                ..Default::default()
+            }),
+            memory: Some(MemoryConfig {
+                size: vm.data.memory.as_u64() as i64,
+                mergeable: Some(false),
+                hotplug_method: Some("Acpi".to_string()),
+                shared: Some(true),
+                hugepages: Some(false),
+                prefault: Some(false),
+                thp: Some(true),
+                ..Default::default()
+            }),
+            payload: PayloadConfig {
+                firmware: Some("/var/lib/odorobo/CLOUDHV.fd".to_string()),
+                ..Default::default()
+            },
+            disks: Some(vec![
+                DiskConfig {
+                    // todo: the json i was given by cappy had disable_io_uring and disable_aio in this config, but I can't find these. I assume they were just a mistake.
+                    path: Some(vm.data.image),
+                    readonly: Some(false),
+                    direct: Some(false),
+                    iommu: Some(false),
+                    num_queues: Some(1),
+                    queue_size: Some(128),
+                    vhost_user: Some(false),
+                    id: Some("_disk0".to_string()),
+                    pci_segment: Some(0),
+                    backing_files: Some(false),
+                    sparse: Some(true),
+                    image_type: Some(ImageType::Raw),
+                    ..Default::default()
+                }
+            ]),
+            net: Some(vec![
+                NetConfig {
+                    id: Some("net://devnet".to_string()),
+                    mac: Some("46:59:52:67:67:67".to_string()),
+                    ..Default::default()
+                }
+            ]),
+            rng: Some(
+                RngConfig {
+                    src: "/dev/urandom".to_string(),
+                    iommu: Some(false)
+                }
+            ),
+            serial: None,
+            debug_console: None,
+            iommu: Some(false),
+            watchdog: Some(false),
+            pvpanic: Some(false),
+            platform: Some(PlatformConfig {
+                serial_number: Some("ds=nocloud".to_string()),
+                ..Default::default()
+            }),
+            landlock_enable: Some(false),
+            ..Default::default()
+        }


most of the options here should be left undefined since Default::default() should default to None and infer to upstream CH itself, having these explicit is probably going to be bad

can you just make a commit setting the default config to whatever you want? You should be able to add commits to the PR. i dont know enough about the cloud hypervisor settings to know what the exact details for all the config options.

Signed-off-by: Caleb Jones <caleb@calebgj.io>

-use crate::state::VMInstance;
-use cloud_hypervisor_client::models::VmConfig;
+use crate::{ch_driver::VMInstance, types::VirtualMachine};
+use cloud_hypervisor_client::models::{CpuFeatures, CpusConfig, DiskConfig, ImageType, MemoryConfig, NetConfig, PayloadConfig, PlatformConfig, VmConfig};


-use crate::state::VMInstance;
-use cloud_hypervisor_client::models::VmConfig;
+use crate::{ch_driver::VMInstance, types::VirtualMachine};
+use cloud_hypervisor_client::models::{CpuFeatures, CpusConfig, DiskConfig, ImageType, MemoryConfig, NetConfig, PayloadConfig, PlatformConfig, VmConfig};


TheHeroBrine422 added 7 commits April 26, 2026 19:22

started this and then realized we might want to merge the crates first

bc4eacd

Signed-off-by: Caleb Jones <caleb@calebgj.io>

start working on affinity rules

46fbede

Signed-off-by: Caleb Jones <caleb@calebgj.io>

remove old ch_api

35dbe69

Signed-off-by: Caleb Jones <caleb@calebgj.io>

rename state module to ch_driver to make more sense. start work on

1c60eac

isolating ch references. will move this to another crate later. Signed-off-by: Caleb Jones <caleb@calebgj.io>

[wip] switch ch_driver to use VirtualMachine instead of VmConfig

05cb7d9

Signed-off-by: Caleb Jones <caleb@calebgj.io>

get vm meta manifest mostly working with odoroboctl

5bf7cd9

Signed-off-by: Caleb Jones <caleb@calebgj.io>

fix a few warnings

33135c4

Signed-off-by: Caleb Jones <caleb@calebgj.io>

TheHeroBrine422 requested a review from korewaChino April 28, 2026 20:21

TheHeroBrine422 linked an issue Apr 28, 2026 that may be closed by this pull request

Proper VM meta-manifest #19

Open

TheHeroBrine422 changed the title ~~cm meta manifest~~ vm meta manifest Apr 28, 2026

korewaChino reviewed Apr 29, 2026

View reviewed changes

address most of cappy's feedback

5ecc312

Signed-off-by: Caleb Jones <caleb@calebgj.io>

github-advanced-security AI found potential problems Apr 29, 2026

View reviewed changes

Comment thread odorobo/src/ch_driver/actor.rs Fixed

Comment thread odorobo/src/ch_driver/actor.rs Fixed

Comment thread odorobo/src/ch_driver/actor.rs Fixed

korewaChino reviewed Apr 29, 2026

View reviewed changes

TheHeroBrine422 and others added 2 commits April 29, 2026 12:44

resolve some of cappy's feedback.

5b666b1

Signed-off-by: Caleb Jones <caleb@calebgj.io>

infer from ch defaults

6acc9ae

github-advanced-security AI found potential problems Apr 30, 2026

View reviewed changes

Conversation

TheHeroBrine422 commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheHeroBrine422 commented Apr 29, 2026

Uh oh!

korewaChino commented Apr 29, 2026

Uh oh!

TheHeroBrine422 commented Apr 29, 2026

Uh oh!

TheHeroBrine422 commented Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheHeroBrine422 commented Apr 29, 2026

Uh oh!

korewaChino Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

TheHeroBrine422 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

korewaChino Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

TheHeroBrine422 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

korewaChino Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

korewaChino Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

korewaChino Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

TheHeroBrine422 Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TheHeroBrine422 commented Apr 28, 2026 •

edited

Loading

TheHeroBrine422 Apr 29, 2026 •

edited

Loading