Repository navigation
Write the full logic of store rpm packages test it via unit tests - #161
Merged
madonuko merged 4 commits intoOct 27, 2026
Merged
Conversation
Edit the repo.rs file to connect the logic of choose between mutlipart and single add missing file
MohammedNaser28
marked this pull request as draft
October 16, 2026 17:20
Contributor
Author
|
@madonuko this is the initial fix for the issue I tested multipart uploads for packages larger than 50 MiB using RustFS, and they worked correctly. I’ll also work on your suggestion to add CI tests using RustFS or MinIO and push the CI changes to this PR once they’re ready. |
madonuko
reviewed
Oct 17, 2026
madonuko
left a comment
madonuko
left a comment
Member
There was a problem hiding this comment.
I decided to review this at 4:22 am and as expected I couldn't understand the poll_write impl, I'll try again tmr.
madonuko
reviewed
Oct 18, 2026
Contributor
Author
|
@madonuko sorry for the delay, I've applied your comments I haven't edit/add new unit tests yet , I will add them in separate commit after review |
Member
|
ok this looks very clean now, tysm again! |
madonuko
reviewed
Oct 24, 2026
MohammedNaser28
marked this pull request as ready for review
October 24, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This the initial implementation for issue #155