Capitalise the father's salutation in the certificate preview - #308
Merged
vikrantwiz02 merged 1 commit intoSep 2, 2026
Merged
vikrantwiz02 merged 1 commit into
vikrantwiz02 merged 1 commit into
Conversation
The certificate body is written twice, once for the PDF and once for the on-screen preview, and only the PDF was capitalised. The preview still addressed the father as Mr. while the student read MR. right beside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bonafide certificate body is written twice — once in the backend for the PDF, once here for the on-screen preview. The salutation was capitalised in the PDF, but the preview kept a hardcoded
Mr.for the father, so the preview readMR. <student>andMr. <father>in the same sentence.The student's salutation was already correct here because it comes from the API; only the father's was hardcoded in the markup. Now
MR.in both.Pairs with FusionIIIT/Fusion#1976 (the PDF wording) and #1977 (refreshing certificates already issued).
429 tests passing, eslint and prettier clean on the file, production build clean.