Topic server conditioning v1 by FukuInTheCode · Pull Request #67 · FukuInTheCode/AREA

FukuInTheCode · 2025-11-03T07:48:58Z

This pull request introduces several significant updates to the CI/CD pipeline configuration and enhances MongoDB serialization for condition models. The main improvements include reactivating and updating orchestrator workflow files for both client and server, and ensuring proper BSON serialization for polymorphic condition elements in the backend.

CI/CD Pipeline Updates:

Reactivated and updated the client orchestrator workflow in .github/workflows/ci-cd-orchestrator.client.yaml, enabling matrix builds and lint/test jobs for the frontend, with placeholders for future Docker and deployment steps.
Reactivated and updated the server orchestrator workflow in .github/workflows/ci-cd-orchestrator.server.yaml, with jobs for solution creation, build, linting, unit tests, Docker build/push, image signing, deployment, and mirroring.
Removed deactivated versions of the orchestrator workflows from .github/workflows_deactivated/ci-cd-orchestrator.client.yaml and .github/workflows_deactivated/ci-cd-orchestrator.server.yaml. [1] [2]

Backend Serialization Improvements:

Added a ConfigureBsonSerialization method in MongoDBContext to register discriminators and class maps for all condition element types implementing IConditionElementModel, ensuring correct BSON serialization/deserialization of polymorphic condition trees. [1] [2]

API Model Handling:

Ensured that the Conditions property from the request is assigned when creating a new Area in AreaV2Controller, supporting the new serialization logic.

…lements and their application, including ConditioningApplyOnEnum, ConditioningElementTypeEnum, and related models for structured conditioning logic

…epresent a collection of condition elements

…l and ConditioningModel classes; introduce ConditionEqualElement class for improved condition handling

…ioningElementTypeEnum, and introduce AreaConditionModel for enhanced condition handling in areas

…able Value property and introduce ConditionNotElement class for enhanced condition handling

…uests to the backend, including support for GET, POST, PUT, DELETE, and OPTIONS methods

…nditionModel with ElementType property for enhanced condition handling

…onditionOrElementModel to use Children property and introduce ConditionAndChildElementModel and ConditionOrChildElementModel for improved condition handling

… ConditionAndChildElementModel and ChildElementType in ConditionNotElement for consistency

…ConditionElementModel for improved flexibility and consistency

…rsion logic for improved robustness and error handling

…payload generation for conditions

… ConditionOrChildElementModel for consistency

… for handling area conditions

…ModelJsonConverter for JSON serialization

…es and payload

…IConditionElementModel and register condition element class maps

Copilot

Pull Request Overview

This PR implements a conditional execution system for Areas V2, adds a proxy route to avoid CORS issues, removes test files, and reactivates CI/CD workflows. Key changes include:

Adds conditions support for Area V2 with logical operators (And, Or, Not, Equals)
Implements a Next.js API proxy to bypass CORS restrictions
Introduces condition nodes in the visual builder UI with diamond-shaped representation
Removes timer-related tests and reactivates GitHub Actions workflows

Reviewed Changes

Copilot reviewed 23 out of 35 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
Server/Services/V2/Area/AreaService.cs	Adds condition verification logic and improved error handling for missing sources
Server/Services/V2/Area/AreaService.Conditions.cs	Implements condition evaluation functions for And/Or/Not/Equals operators
Server/Models/V2/*.cs	Defines condition data models and interfaces
Server/Converters/ConditionElementJsonConverter.cs	Implements custom JSON serialization for polymorphic condition elements
Server/Contexts/MongoDbContext.cs	Configures BSON serialization for condition element interface types
Tests/controller-tester/lib/api.ts	Updates API client to use proxy route instead of direct API calls
Tests/controller-tester/app/api/proxy/[...path]/route.ts	Implements Next.js API proxy to forward requests and handle CORS
Tests/controller-tester/app/area-v2-builder/page.tsx	Adds visual condition node builder with modal editor UI
.github/workflows/*.yaml	Reactivates CI/CD workflows for server and client builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T07:53:13Z

        return Task.CompletedTask;
    }

+    public bool VerifyCoditions(string? source, List<ActionOutputModel> outputs, List<AreaConditionModel> conditions)


Corrected spelling of 'VerifyCoditions' to 'VerifyConditions'.

Copilot · 2025-11-03T07:53:13Z

    {
        Console.WriteLine($"Processing action for area {area.Id}");
        Console.WriteLine($"Action result: {JsonConvert.SerializeObject(actionResult)}");
+        if (!VerifyCoditions(null, actionResult.Outputs ?? [], area.Conditions ?? []))


Corrected spelling of 'VerifyCoditions' to 'VerifyConditions'.

Copilot · 2025-11-03T07:53:13Z

            var reactionResult = await reactionInput(user, area, inputs);
            // Store outputs for this reaction by its name for downstream references
-            if (!string.IsNullOrWhiteSpace(reaction.Name))
+            if (!string.IsNullOrWhiteSpace(reaction.Name) && VerifyCoditions(reaction.Name!, reactionResult ?? [], area.Conditions ?? []))


Corrected spelling of 'VerifyCoditions' to 'VerifyConditions'.

Copilot · 2025-11-03T07:53:13Z

+using System.ComponentModel;
+using MongoDB.Bson.Serialization.Serializers;
+using System.Diagnostics;


These imports appear to be unused. Line 22 (System.ComponentModel), line 23 (MongoDB.Bson.Serialization.Serializers), and line 24 (System.Diagnostics) should be removed if they are not used elsewhere in the file to keep imports clean.

Copilot · 2025-11-03T07:53:14Z

            var reactionInput = GetReactionInput(reaction.Type);
-            var inputs = reaction.Parameters?.Select(param => ConvertToReactionInput(param, outputsBySource)).ToList() ?? new List<ReactionInputModel>();
+            var inputs = reaction.Parameters?.Select(param => ConvertToReactionInput(param, outputsBySource)).OfType<ReactionInputModel>().ToList() ?? [];
+            if (inputs.Count != 0 && inputs.Any(x => x == null))


The condition inputs.Any(x => x == null) will never be true because line 297 uses OfType<ReactionInputModel>() which filters out null values. This check is redundant and unreachable. Either remove this check or verify the intended logic.

Copilot · 2025-11-03T07:53:14Z

+            foreach (var child in orElement.Children)
+            {
+                if (child.ElementType == null || child.Element == null)
+                    continue;
+                var childFunc = GetVerifyConditionsFunction(child.ElementType ?? throw new Exception("Unexpected error"));
+                if (childFunc == null)
+                    continue;
+                if (childFunc(source, output, child.Element ?? throw new Exception("Unexpected error")))
+                    return true;
+            }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2025-11-03T07:53:14Z

+        foreach (var condition in conditions)
+        {
+            if (condition.ElementType == null)
+                continue;
+            var output = outputs.FirstOrDefault(output => output.Name == condition.OutputName);
+            if (output == null)
+                continue;
+            var verifyConditions = GetVerifyConditionsFunction(condition.ElementType.Value);
+            if (verifyConditions == null || condition.Element == null)
+                continue;
+            if (!verifyConditions(source, output, condition.Element))
+                return false;
+        }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2025-11-03T07:53:15Z

 {
    public static MongoClient Client { get; set; }
    private static readonly object _lock = new();
+    private static bool _isConfigured = false;


Field '_isConfigured' can be 'readonly'.

Suggested change

private static bool _isConfigured = false;

private static readonly bool _isConfigured = false;

Copilot · 2025-11-03T07:53:15Z

+            if (output.IsList && output.Values != null)
+                return output.Values.Any(value => value == expected);
+            else
+                return output.Value == expected;


Both branches of this 'if' statement return - consider using '?' to express intent better.

Suggested change

if (output.IsList && output.Values != null)

return output.Values.Any(value => value == expected);

else

return output.Value == expected;

return (output.IsList && output.Values != null)

? output.Values.Any(value => value == expected)

: output.Value == expected;

Copilot · 2025-11-03T07:53:15Z

+        if (string.IsNullOrEmpty(source))
+            conditions = [.. conditions.Where(condition => condition.Source == null || string.Equals(condition.Source, "Action", StringComparison.OrdinalIgnoreCase))];
+        else
+            conditions = [.. conditions.Where(condition => condition.Source == source)]; // case sensitive


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

FukuInTheCode added 20 commits November 1, 2025 09:59

feat(Conditioning): introduce new enums and models for conditioning e…

624e518

…lements and their application, including ConditioningApplyOnEnum, ConditioningElementTypeEnum, and related models for structured conditioning logic

chore(api): update API base URL to use secure HTTPS endpoint

68dbae5

feat(ConditionOrElementModel): add ConditionOrElementModel class to r…

96a60fa

…epresent a collection of condition elements

refactor(ConditioningModels): remove outdated ConditioningElementMode…

0f70697

…l and ConditioningModel classes; introduce ConditionEqualElement class for improved condition handling

refactor(Conditioning): remove ConditioningApplyOnEnum, update Condit…

10e6a60

…ioningElementTypeEnum, and introduce AreaConditionModel for enhanced condition handling in areas

refactor(ConditionModels): update ConditionEqualElement to allow null…

430fd6a

…able Value property and introduce ConditionNotElement class for enhanced condition handling

feat(proxy): implement API proxy route to handle CORS and forward req…

861922e

…uests to the backend, including support for GET, POST, PUT, DELETE, and OPTIONS methods

feat(AreaService): add condition verification logic and extend AreaCo…

5f51d5d

…nditionModel with ElementType property for enhanced condition handling

refactor(ConditionModels): restructure ConditionAndElementModel and C…

fba853f

…onditionOrElementModel to use Children property and introduce ConditionAndChildElementModel and ConditionOrChildElementModel for improved condition handling

refactor(ConditionModels): rename Operator property to ElementType in…

9190430

… ConditionAndChildElementModel and ChildElementType in ConditionNotElement for consistency

refactor(AreaService): update condition verification methods to use I…

ff43cb5

…ConditionElementModel for improved flexibility and consistency

refactor(AreaService): enhance condition verification and input conve…

4601266

…rsion logic for improved robustness and error handling

feat(AreaService): implement condition node handling with editor and …

cbeb01d

…payload generation for conditions

refactor(ConditionModels): rename Operator property to ElementType in…

58b4fd7

… ConditionOrChildElementModel for consistency

feat(CreateAreaRequest): add Conditions property to CreateAreaRequest…

49cc6b1

… for handling area conditions

feat(Converters): add ConditionElementJsonConverter and AreaCondition…

c37f270

…ModelJsonConverter for JSON serialization

feat(AreaV2BuilderPage): add console logs for debugging condition nod…

32c6cd7

…es and payload

feat(MongoDBContext): implement BSON serialization configuration for …

d1f42f1

…IConditionElementModel and register condition element class maps

feat(cicd): reactivated

b2294e5

refactor(tests): remove TimerMongoServiceTests class

53111fd

FukuInTheCode added this to the Final Product milestone Nov 3, 2025

FukuInTheCode requested a review from Copilot November 3, 2025 07:48

FukuInTheCode self-assigned this Nov 3, 2025

FukuInTheCode added enhancement New feature or request Server labels Nov 3, 2025

FukuInTheCode requested a review from EmmaFrx November 3, 2025 07:49

EmmaFrx merged commit dfd2be1 into main Nov 3, 2025
17 checks passed

Copilot AI reviewed Nov 3, 2025

View reviewed changes

Navigation Menu

Repository navigation

Topic server conditioning v1 - #67

Topic server conditioning v1#67
EmmaFrx merged 20 commits into
mainfrom
topic-server-conditioning-v1

FukuInTheCode commented Nov 3, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	private static bool _isConfigured = false;
	private static readonly bool _isConfigured = false;

Conversation

FukuInTheCode commented Nov 3, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants