Add a "consider a lower level" hint for very noisy runs - #1069
Open
skerbis wants to merge 1 commit into
Open
Conversation
When a run reports more than 200 problems (a rough heuristic) at a level above 0, a hint now points at the settings page to choose a lower level and work back up from there. PHPStan's levels are themselves already a priority ordering - each level builds on every check from the levels below it - so this uses that existing lever instead of introducing a separate, parallel categorization scheme. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
Member
|
warum als target branch der große feature branch? |
Member
Author
|
Weil der Code, den diese PR ändert ( Ist bewusst kein Stack im klassischen Sinn - die PR hängt nur an #1067, nicht an einer anderen offenen PR. #1068 z.B. ist eine unabhängige Schwester-PR daneben, keine Voraussetzung hier. Hatten wir vorher als 5er-Kette am Laufen, die haben wir extra aufgelöst, weil das unübersichtlich wurde. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent sibling of #1068 (the trigger/UI-polish PR) — both are based on #1067 but not on each other. Reopens the content of #1065 unchanged (that PR was already cleaned up to this minimal diff per @staabm's review), now as a standalone PR instead of the last link in a 5-deep chain.
When a run reports more than 200 problems (a rough heuristic) at a level above 0, a hint now points at the settings page to choose a lower level and work back up from there. PHPStan's levels are themselves already a priority ordering — each level builds on every check from the levels below it — so this uses that existing lever instead of introducing a separate, parallel categorization scheme (an earlier version of this change added exactly such a scheme via a
RexStanCategorizer; removed per review feedback).Touches only
lib/RexResultsRenderer.phpandCHANGELOG.md.Test plan
php -l+ PHPStan on all changed files: 0 findings.🤖 Generated with Claude Code