Skip to content

Add a real animated spinner for the "running" placeholder - #1064

Closed
skerbis wants to merge 1 commit into
fix/analysis-rerun-button-click-handlerfrom
fix/analysis-running-placeholder-spinner
Closed

skerbis wants to merge 1 commit into
fix/analysis-rerun-button-click-handlerfrom
fix/analysis-running-placeholder-spinner

Conversation

@skerbis

@skerbis skerbis commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

Stacked on #1063 (click-handler fix) — please review/merge that one first.

The running-state placeholder referenced a rexstan-analysis-spinner CSS class that was never actually defined - just a static hourglass emoji with no animation at all, easy to miss.

Added a small rotating CSS spinner (assets/rexstan.css) and render the exact same placeholder markup server-side in pages/analysis.php as well as from JS, so it's visible and animated purely via CSS immediately on page load when a run is already in progress, without depending on JS having initialized yet.

Test plan

  • Verified the spinner markup and CSS class render correctly server-side (forced a "running" lock state and checked the output).
  • php -l on the changed file.

🤖 Generated with Claude Code

The running-state placeholder referenced a rexstan-analysis-spinner
CSS class that was never actually defined - just a static hourglass
emoji with no animation at all, easy to miss.

Added a small rotating CSS spinner (assets/rexstan.css) and render
the exact same placeholder markup server-side in pages/analysis.php
as well as from JS, so it's visible and animated purely via CSS
immediately on page load when a run is already in progress, without
depending on JS having initialized yet.

Also updates the CHANGELOG with the previous commit's button-click
fix, which hadn't been documented there yet.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@skerbis

skerbis commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Closing as part of flattening the stack into independent PRs — this and #1062/#1063 are being combined into one PR ("Harden, fix and animate the analysis re-run trigger"), based on #1067 instead of chained serially. Will link the replacement here once opened.

@skerbis

skerbis commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Combined into #1068.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant