Repository navigation
Conversation
* PHP >= 8.2 * symfony/http-client ^6.4|^7.4|^8.1 * psr/log ^2|^3 * Switch from symfony/phpunit-bridge to phpunit/phpunit * Update CI (actions/checkout, hashicorp/consul image)
* readonly classes and properties * constructor property promotion * first-class callable syntax, array_is_list(), catch without variable * inline trivial $params arrays in services * split MultiSemaphore::acquireResources() and fix the metadata of a previous resource leaking into the next one
Consul expects a JSON object, but an empty array was sent. This also broke LockHandler::lock(). Add tests for LockHandler and TXN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the library. It can be reviewed commit by commit.
1. Drop support for unmaintained versions
symfony/http-client:^6.4|^7.4|^8.1(5.4, 7.0-7.3 and 8.0 are no longer maintained)psr/log:^2|^3symfony/phpunit-bridgetophpunit/phpunit(11.5, 12, 13)actions/checkout@v5,hashicorp/consul:2.0(theconsulimage is deprecated), prefer-lowest on PHP 8.22. Use PHP 8.2 features
array_is_list(), catch without variable,mixed$paramsarrays in servicesMultiSemaphore::acquireResources()into smaller pieces. This also fixesa bug: the metadata of a resource leaked into the next one when acquiring many
resources (wrong
casindex, wrong sessions list)No BC break on the public API.
3. Bug fix:
Session::create()without argumentsSession::create()sent[]instead of{}, and Consul rejects it with a 400.This broke
LockHandler::lock()(and the README example). Tests added forLockHandlerandTXN.4. README
New README with badges, features, configuration (
CONSUL_HTTP_ADDR, ACL token,custom client / logger), a services table linked to the Consul API docs, error
handling, a richer cookbook, and a compatibility table. All snippets were run
against a Consul 2.0 agent.