Skip to content

Update PHP and PHPUnit version requirements #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 2 commits into from
May 11, 2026
Merged

Update PHP and PHPUnit version requirements #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e493a15
Update PHP and PHPUnit version requirements
dereuromark Apr 12, 2026
2ff238a
Update PHP version requirement to 8.2
dereuromark Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
}
],
"require": {
"php": ">=8.2",

@ADmad ADmad Apr 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CakePHP constraint is 5.1+ which supports PHP 8.1. So can't use >=8.1?

@dereuromark dereuromark Apr 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually already only testing 8.2+
Using 8.1 now makes no sense IMO - we dont even know if it would work still (hidden 8.2 language could be anywhere).

Also those are two different dimensions, you can use Cake 5.1 just fine with 8.2+
All my plugins and apps did too.
See https://github.com/dereuromark/cakephp-ide-helper/blob/083693f2c099663a0bbb047bf76c47a9f82cf839/composer.json#L34-L36

@dereuromark dereuromark Apr 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a minor bump of course.
But its no big deal either way, since composer would just not pull it if the setup is not compatible.

@ADmad ADmad Apr 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, let's do it with a minor bump

"cakephp/cakephp": "^5.1.4"
},
"require-dev": {
"phpunit/phpunit": "^10.5.58 || ^11.5.3 || ^12.4",
"phpunit/phpunit": "^11.5.3 || ^12.4 || ^13.0",
"cakephp/bake": "^3.0",
"cakephp/cakephp-codesniffer": "^5.1"
},
Expand Down
Loading