Added support for SI Schedule+Register form (StudioIntern)#167
Added support for SI Schedule+Register form (StudioIntern)#167RealZendor wants to merge 2 commits intoFriendlyCaptcha:mainfrom
Conversation
|
Don't know if I am allowed to change the plugin's version number. That's why I didn't. Please change version number before committing the merged repo. |
|
|
||
| if (empty($solution)) { | ||
| /* translators: Error message when captcha was not completed */ | ||
| return __("Bitte lösen Sie das Anti-Spam-Rätsel.", "frcaptcha"); |
There was a problem hiding this comment.
Is this integration only relevant to german speaking users? All our other error messages are in english, I think it would be best to keep it that way.
There was a problem hiding this comment.
Yes, most StudioIntern users (and their customers) speak German.
| "slug" => 'tws_siwp', | ||
| "entry" => "tws-siwp/tws-siwp.php", | ||
| "plugins" => array("tws-siwp/tws-siwp.php"), | ||
| "settings_description" => "Enable Friendly Captcha for the SI Schedule+Registration trial lesson signup form.", |
There was a problem hiding this comment.
I think it would be best to link to the relevant website here, so users understand what this integration is for :)
|
Hey, thanks for the PR! If I see it correctly you are part of the StudioIntern team, so I wonder if it wouldn't be best to integrate Friendly Captcha into the StudioIntern Wordpress plugin and not the other way around? We have a PHP SDK which should make it fairly easy to integrate it into your plugin. This way you have better control over how Friendly Captcha is integrated and users don't have to install the separate Friendly Captcha Wordpress plugin. What do you think? |
|
Yes, you are right. I am the author and provider of StudioIntern. In fact, trying to integrate FC directly into my plugin was my very first idea. It first seemed to work. But it didn't. There were some strange phenomenas. On my lokal dev machine, it worked perfectly. On production, FC provided a different "version". Look at these screenshots: |
|
This looks like to be mix of Friendly Captcha v1 and v2. The first screenshot shows Friendly Captcha v2 but the second one shows Friendly Captcha v1. This is probably because the wrong scripts are included on the live site. You most definitely want Friendly Captcha v2 and I would guess the integration of v1 on the live site was done by mistake. This would also explain why the form field was empty, v1 uses a different form field name than v2. You can find more information on v1 and v2 here: And the integration guide for v2: Let me know if you have any more questions or need further help with the integration :) |
|
It's impossible being a wrong script included only on the live site. As I mentioned before, the whole plugin code was identical on dev and live. |
|
What I see on the screenshot is definitely a mix up between v1 and v2. The two versions work completely different, so it's impossible that they are shown with the script. |
|
Oh yes! This seems to explain what happened. My customer does have the public FC plugin installed because he uses it elsewhere on the site. I didn't know about that. |
2 participants
What is SI Schedule+Register?
SI Schedule+Register is a Wordpress PlugIn which can fetch dance class schedules from a StudioIntern SaaS instance and display it inside a Wordpress page. Further, it can display a registration form / trial lesson appointment form which then will be sent to the StudioIntern instance.
What is the change intended for?
The changes I made is simply adding a module to support the StudioIntern SI Schedule+Register form.
Where can I get more information on StudioIntern and this special form?
For information on StudioIntern in general, visit https://www.ballettschul-software.de/ .
For information about the SI Schedule+Register WP Plugin, see https://www.ballettschul-software.de/zusatzmodule.php#sischedreg
Send support requests to support@studiointern.de .