Skip to content

Merge: Fix int types for enclosures#74

Merged
Alkarex merged 2 commits intofreshrssfrom
merge-fix-enclosure-int-types
Apr 17, 2026
Merged

Merge: Fix int types for enclosures#74
Alkarex merged 2 commits intofreshrssfrom
merge-fix-enclosure-int-types

Conversation

@Alkarex
Copy link
Copy Markdown
Member

@Alkarex Alkarex commented Apr 17, 2026

channels, duration were wrongly parsed as string instead of int.

PHP Fatal error:  Uncaught TypeError: SimplePie\Enclosure::__construct():
Argument #12 ($duration) must be of type ?int, string given in simplepie/src/Enclosure.php:199

And add tests (there were none for those attributes)

Downstream issue:

Upstream PR:

Alkarex added 2 commits April 17, 2026 14:12
channels, duration were wrongly parsed as string instead of int.

```
PHP Fatal error:  Uncaught TypeError: SimplePie\Enclosure::__construct(): Argument #12 ($duration) must be of type ?int, string given in simplepie/src/Enclosure.php:199
```

And add tests (there were none for those attributes)

Downstream issue:
* FreshRSS/FreshRSS#8701
@Alkarex Alkarex added the bug label Apr 17, 2026
@Alkarex Alkarex merged commit 33e4bcf into freshrss Apr 17, 2026
20 checks passed
@Alkarex Alkarex deleted the merge-fix-enclosure-int-types branch April 17, 2026 21:39
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Apr 17, 2026
channels, duration were wrongly parsed as string instead of int.

```
PHP Fatal error:  Uncaught TypeError: SimplePie\Enclosure::__construct():
Argument #12 ($duration) must be of type ?int, string given in simplepie/src/Enclosure.php:199
```

And add tests (there were none for those attributes)

fix FreshRSS#8701

Upstream PR:
* simplepie/simplepie#975
* FreshRSS/simplepie#74
Alkarex added a commit to FreshRSS/FreshRSS that referenced this pull request Apr 17, 2026
channels, duration were wrongly parsed as string instead of int.

```
PHP Fatal error:  Uncaught TypeError: SimplePie\Enclosure::__construct():
Argument #12 ($duration) must be of type ?int, string given in simplepie/src/Enclosure.php:199
```

And add tests (there were none for those attributes)

fix #8701

Upstream PR:
* simplepie/simplepie#975
* FreshRSS/simplepie#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant