Repository navigation
Theme: Add nginx redirects template based on Aliases - #95
Merged
Merged
Conversation
github-actions
Bot
added
Config
Collaborator
Author
Member
|
Thanks, I'll review this and then get it set up server-side to use the new file. |
marcuspollio
force-pushed
the
redirects
branch
from
October 7, 2026 16:32
2e21201 to
3fe5855
Compare
chennes
requested changes
Oct 15, 2026
| title: Innovate without limits | ||
| linkTitle: Features | ||
| description: Powerful and open parametric design for everyone. | ||
| aliases: ["/features"] |
Member
There was a problem hiding this comment.
This one doesn't work: the section is already called "features", so this results in a circular self-redirecting loop.
Member
|
@marcuspollio I've added a commit that makes a few tweaks to your setup here: give it a look. |
Contributor
|
@marcuspollio good to go? |
Collaborator
Author
|
Hi @chennes I've pushed another update as well: this adds support for directly redirecting pages that have the So now, for 301.nginx contentLet me know if this is fully OK for you (including the path and filename of this file), then we can merge. |
Contributor
|
@marcuspollio PR has a conflict |
Also add old homepage URLs, and resolve targets the way the menus do. Finally, check against the allowed character set to prevent any sort of injection.
marcuspollio
force-pushed
the
redirects
branch
from
October 21, 2026 07:34
17f8268 to
de81dd1
Compare
Member
|
This now maps maps the non-trailing-slash form (e.g. We should also decide what do do about the Code of Conduct and Privacy pages -- they are marked as Draft, so they aren't built, and their aliases aren't generated. So we need to hide them from the listings, or switch them out of draft, or something. We should also catch the old FPN links and redirect them someplace neutral and at least somewhat useful. I've added a new commit that takes care of all of these, @marcuspollio please give it a look. I'm still a total newb at Hugo so I'm learning as I go... |
marcuspollio
commented
Oct 23, 2026
Collaborator
Author
There was a problem hiding this comment.
Thanks! Look good and fairly complete now.
So I just checked:
- every internal page with a redirect to an external URL now gets listed in the map both with and without a trailing slash, which is what we want. For some reasons, I had no issues with any of the two on my side when entering the address manually (Firefox 158).
- the codeofconduct/CODE_OF_CONDUCT and privacy/PRIVACY_POLICY combos work as expected, that is properly listed in the redirects map without their html page being built.
We now have about 600 entries in the redirects map.
When approved, I can merge. Can it be tested already on the staging environment?
chennes
approved these changes
Oct 23, 2026
Member
|
I have to make one server-side change once this is merged, then we can test it on staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Hugo-generated server-side URLs redirects file at
/public/.nginx/301.nginx, as part of #89.The file structure is similar to (excerpt):
Basically, for each page with
Aliases, a map of paths is created with first the old URL and then the new one.Old URLs can be
/<old>,/<old>/,/<old>.php, or/<old>.php?lang=<locale>.New URLs are either the default English
/<new>/, or if the translation is enabled/<lang>/<new>/.Page with
Aliasesare currently: Code of Conduct, Privacy Policy, Calendar, Professional Network, Development Handbook, Donate, Download, Addons, Features, and News.For references, see Hugo URL management and Aliases documentation.
For references, I used a
wgetof the current "old" FreeCAD website pages:Log after cleanup
PR checklist