Skip to content

Fix/completion and release security - #91

Merged
Fred-Wu merged 3 commits into
mainfrom
fix/completion-and-release-security
Nov 18, 2026
Merged

Fred-Wu merged 3 commits into
mainfrom
fix/completion-and-release-security

Conversation

@Fred-Wu

@Fred-Wu Fred-Wu commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Prevent S4 slot completion (@) from evaluating a subscript before the user submits the command. The console still shows slots the language server can infer.
  • Preserve the exact unsigned runtime binary when reusing a previous release. Packaging now verifies its SHA-256 against a reviewed digest for each platform and runtime version. Changes to build.rs also trigger the Windows runtime version check.
  • Switch Open VSX to trusted publishing with a lockfile-pinned CLI. Version-tag pushes publish automatically, and manual publishing is limited to main. The job uses the open-vsx repository environment.

Verification

  • Type-check passed. 570 unit tests passed with 3 skipped. All 49 language-server tests and 14 Rust tests passed.
  • Verified the published runtime digests across all six platforms and confirmed that altered binaries fail verification. Both repackaged Windows executables were byte-for-byte identical to their published versions.
  • Production dependency audit reported zero vulnerabilities. The pinned Open VSX CLI inherits the existing development-only VSCE advisory exception.

@Fred-Wu
Fred-Wu marked this pull request as ready for review November 18, 2026 11:39
@Fred-Wu
Fred-Wu merged commit 89890c5 into main Nov 18, 2026
9 checks passed
@Fred-Wu
Fred-Wu deleted the fix/completion-and-release-security branch November 18, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant