Fix routes and deps for Rails 8.1 compatbility#1
Merged
Conversation
filippoliverani
force-pushed
the
filippoliverani/fix-routes
branch
from
4489477 to
056d9e1
Compare
Allows future Solidus and Solidus support versions
Extends the User monkey patch to work with both Solidus Spree::LegacyUser and SolidusAuthDevise Spree::User
Updates routes definition to stop using deprecated multiple positional args.
filippoliverani
force-pushed
the
filippoliverani/fix-routes
branch
from
056d9e1 to
25a2b2e
Compare
filippoliverani
changed the title
schimpf
approved these changes
May 18, 2026
schimpf
left a comment
schimpf
left a comment
There was a problem hiding this comment.
Changes make sense, testing this in the PR bumping the rails version to 8.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies and routes definition to be compatible with Solidus 4.7 and Rails 8.1