Wireshark: fix fatal warnings for in-tree build#300
Merged
Conversation
Fix sources of warnings in `packet-ja4.c` which cause in-tree build to fail, due to upstream Wireshark's use of `-Werror`. (As tested on Windows build using Visual Studio 2022.) Remove custom `array_length()` macro and use `<wsutil/array.h>` instead, to avoid warnings about macro redefinition. It's been around long enough now that this plugin can now safely depend on it. Change loop indexes from `int` to `unsigned` to prevent warnings about signed/unsigned mismatches in comparisons.
vlvkobal
approved these changes
Jun 9, 2026
Member
|
After this is merged, we won't support Wireshark < @igr001-galactica, what do you think? If we agree to drop support for older versions, we should update the README files as well. Alternatively, we can keep support for older versions using preprocessor conditionals. |
vlvkobal
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sources of warnings in
packet-ja4.cwhich cause in-tree build to fail, due to upstream Wireshark's use of-Werror. (As tested on Windows build using Visual Studio 2022.)Remove custom
array_length()macro and use<wsutil/array.h>instead, to avoid warnings about macro redefinition.It's been around long enough now that this plugin can now safely depend on it.
Change loop indexes from
inttounsignedto prevent warnings about signed/unsigned mismatches in comparisons.