Fix: Update ja4t logic to output padded zeroes for missing options#296
Merged
Conversation
* fix: update ja4t logic to output padded zeroes for missing options Updates `ja4t` and `ja4ts` format logic in Zeek to match the spec: - Missing TCP options output as `00` instead of empty. - Missing or zero-value MSS output as `00` instead of `0`. - Missing or zero-value Window Scale output as `00` instead of `0`. Updates corresponding btest baselines. chore: remove .btest.failed.dat and add to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
ja4tandja4tsformat logic in Zeek to match the spec:00instead of empty.00instead of0.00instead of0.Updates corresponding btest baselines.
chore: remove .btest.failed.dat and add to .gitignore