Fix JA4L TCP packet selection in Wireshark plugin#294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Wireshark JA4 dissector so TCP JA4L follows the spec for timestamps
D,E, andF.Previously, the plugin guessed packet direction from port heuristics like
srcport < 5000/dstport < 5000and only treated exactPSH, ACKpackets as application data. That could pick the wrongEpacket, even though the spec definesEas the first server application packet.Changes
D,E, andFbased on real connection directiontcp.len > 0), not just exactPSH, ACKWhy
Per the JA4L spec:
Das the first client application packet after the TCP handshakeEas the first server application packet afterDFas the first client application packet afterEThis change makes the plugin match that behavior.