Skip to content

Add contract test, document cleanup_stream, and Storybook stories for components - #1063

Merged
Austinaminu2 merged 2 commits into
FlowwStar:mainfrom
Joel234-png:batch-159-features
Oct 20, 2026
Merged

Austinaminu2 merged 2 commits into
FlowwStar:mainfrom
Joel234-png:batch-159-features

Conversation

@Joel234-png

Copy link
Copy Markdown
Contributor

…

Closes #1051
Closes #1052
Closes #1053
Closes #1054


name: Pull request
about: Describe a focused change and how it was verified
title: 'feat: '
labels: enhancement

Issue

Closes #

Summary

Describe the user or maintainer-facing change.

Changes

Test plan

  • I added or updated automated tests.
  • I ran the relevant test suite.
  • I checked the change in the affected environment.

Checklist

  • The change is scoped to the linked issue.
  • Documentation and configuration were updated where needed.
  • No secrets, private keys, or wallet credentials are included.

… components

Closes FlowwStar#1051, FlowwStar#1052, FlowwStar#1053, FlowwStar#1054

- Add test_cleanup_stream_succeeds_while_paused to verify cleanup_stream works while paused since it only removes storage without modifying state (issue FlowwStar#1051)
- Document in cleanup_stream doc comment that there is no require_not_paused guard (issue FlowwStar#1051)
- Add NotificationBell Storybook stories covering no notifications, unread, and long list (issue FlowwStar#1052)
- Add WebhookSettings Storybook stories covering empty state, registered webhook, and delivery history (issue FlowwStar#1053)
- Add AddressBookSettings Storybook stories covering empty book and book with entries (issue FlowwStar#1054)
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Joel234-png Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Austinaminu2
Austinaminu2 merged commit 6afa772 into FlowwStar:main Oct 20, 2026
1 of 8 checks passed

This branch had an error being deployed

1 failed deployment
staging — ef5ed914 Deployed Oct 20, 2026 by Austinaminu2 via deploy-staging #358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants