Maven central release#119
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughPOM updated: adds project URL, upgrades maven-release-plugin to 3.0.1 (bound to ChangesMaven Central Publishing Setup
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pom.xml`:
- Around line 179-182: The release profile currently activates only the profile
identified by "release" via the releaseProfiles element, which omits the
"directory" profile that declares the maven-source-plugin and
maven-javadoc-plugin; update the releaseProfiles configuration (the
<releaseProfiles> value) to include both "release" and "directory" so that
running release:perform also activates the "directory" profile and produces
source and javadoc JARs required by Maven Central.
- Around line 530-556: Update the maven-gpg-plugin version in the gpg profile:
locate the <profile> with <id>gpg</id> and the plugin element for
org.apache.maven.plugins:maven-gpg-plugin (artifactId maven-gpg-plugin) and
change its <version> from 3.2.7 to 3.2.8 so the profile uses the latest plugin
release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| <version>3.0.1</version> | ||
| <configuration> | ||
| <releaseProfiles>release</releaseProfiles> | ||
| </configuration> |
There was a problem hiding this comment.
Include directory profile in releaseProfiles for sources and javadoc.
The release profile only contains the publishing plugin, but Maven Central requires source and javadoc JARs. Those plugins are defined in the directory profile (lines 296-331). When release:perform runs, it will only activate the release profile, causing Maven Central validation to fail due to missing artifacts.
🛠️ Proposed fix
<configuration>
- <releaseProfiles>release</releaseProfiles>
+ <releaseProfiles>release,directory</releaseProfiles>
</configuration>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <version>3.0.1</version> | |
| <configuration> | |
| <releaseProfiles>release</releaseProfiles> | |
| </configuration> | |
| <configuration> | |
| <releaseProfiles>release,directory</releaseProfiles> | |
| </configuration> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pom.xml` around lines 179 - 182, The release profile currently activates only
the profile identified by "release" via the releaseProfiles element, which omits
the "directory" profile that declares the maven-source-plugin and
maven-javadoc-plugin; update the releaseProfiles configuration (the
<releaseProfiles> value) to include both "release" and "directory" so that
running release:perform also activates the "directory" profile and produces
source and javadoc JARs required by Maven Central.
There was a problem hiding this comment.
@coderabbitai Please create an issue about this.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
gh issue create \
--repo FlowingCode/YearMonthCalendarAddon \
--assignee javier-godoy \
--title "Include 'directory' profile in releaseProfiles for Maven Central source and javadoc JARs" \
--body "## Problem
When \`release:perform\` is executed, Maven activates only the profiles listed in \`<releaseProfiles>\`. Currently, only the \`release\` profile is listed (see \`pom.xml\`), which activates the \`central-publishing-maven-plugin\`.
However, the \`maven-source-plugin\` and \`maven-javadoc-plugin\` executions that produce the required source and javadoc JARs are declared in the **\`directory\`** profile. Because that profile is not activated during the release, Maven Central validation will fail due to missing source/javadoc artifacts.
## Expected behavior
The \`<releaseProfiles>\` configuration should include both \`release\` and \`directory\` so that running \`release:perform\` also activates the \`directory\` profile and produces all artifacts required by Maven Central.
## References
- Pull request: https://github.com/FlowingCode/YearMonthCalendarAddon/pull/119
- Review comment: https://github.com/FlowingCode/YearMonthCalendarAddon/pull/119#discussion_r3373145159
_Reported by `@coderabbitai` on behalf of `@javier-godoy._`"Length of output: 1367
@javier-godoy, the issue has been created and assigned to you: https://github.com/FlowingCode/YearMonthCalendarAddon/issues/120
There was a problem hiding this comment.
This comment has been deferred for later analysis.
|
1 participant
Summary by CodeRabbit