refactor: split into core library and per-version test modules

[javier-godoy]

Compile the library once against Vaadin 14 in a self-contained core module, and run a single shared test suite against Vaadin 14/23/24/25 via dedicated test-v* modules. Each test module adds the shared sources from tests-shared via build-helper and pins its own Vaadin runtime; surefire selection runs the legacy (*Test24) suites on 14/23/24 and the Jackson (*Test25) suites on 25.

Close #34

[coderabbitai]

Warning

Review limit reached

@javier-godoy, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 10 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 085714e5-79f0-4d00-b880-42fe5eb0709d

📥 Commits

Reviewing files that changed from the base of the PR and between a48a586 and 0c7f7d4.

📒 Files selected for processing (118)

• core/pom.xml
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ClassInstrumentationJacksonHelper.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ClassInstrumentationUtil.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalArrayNode.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalBooleanNode.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNodeAsmPostProcessor.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNullNode.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalNumberNode.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalObjectNode.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalPendingJavaScriptResult.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/ElementalStringNode.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentationViewInitializer.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/InstrumentedRoute.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/JsonCodec.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigration.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper25.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/JsonSerializer.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/LegacyJsonMigrationHelper.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/LitRendererAsmPostProcessor.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/LitRendererMigrationExtension.java
• core/src/main/java/com/flowingcode/vaadin/jsonmigration/UnsupportedJsonValueImpl.java
• pom.xml
• tests-shared/pom.xml
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/BaseClientCallable.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_ArrayOfJsonObject__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_D__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_I__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonArray__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonBoolean__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonNull__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonNumber__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonObjectVarargs__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonObject__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonString__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_JsonValue__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_String__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable_Z__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__D.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__I.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__Integer.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonArray.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonBoolean.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonNull.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonNumber.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonObject.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonString.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__JsonValue.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallable__Z.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest24.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ClientCallablesTest25.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/ExtendsLegacyClientCallablePrivate__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/JsonMigrationHelper25Test.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_D__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_I__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonArray__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonBoolean__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonNull__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonNumber__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonObject__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonString__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_JsonValue__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_String__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate_Z__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__D.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__I.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__Integer.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonArray.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonBoolean.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonNull.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonNumber.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonObject.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonString.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__JsonValue.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablePrivate__Z.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_AllowInert__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_ArrayOfJsonObject__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_ArrayOfJsonString__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_D__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_I__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonArray__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonBoolean__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonNull__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonNumber__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonObjectVarargs__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonObject__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonString__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_JsonValue__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_String__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable_Z__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__D.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__I.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__Integer.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonArray.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonBoolean.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonNull.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonNumber.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonObject.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonString.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__JsonValue.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__V.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallable__Z.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest24.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesPrivateTest25.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest24.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LegacyClientCallablesTest25.java
• tests-shared/src/test/java/com/flowingcode/vaadin/jsonmigration/LitRendererMigrationExtensionTest.java
• tests-shared/src/test/java/com/vaadin/flow/component/internal/AllowInert.java
• tests-v14/pom.xml
• tests-v23/pom.xml
• tests-v24/pom.xml
• tests-v25/pom.xml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch split-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}