Skip to content

Migrate to DownloadHandler API for Vaadin 25 compatibility #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlopezFC wants to merge 3 commits into
base: master
Choose a base branch
from

refactor: extract common logic in a separate class

7dc08a4
Select commit
Loading
Failed to load commit list.
Open

Migrate to DownloadHandler API for Vaadin 25 compatibility #189

refactor: extract common logic in a separate class
7dc08a4
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 3, 2026 in 17s

Quality Gate failed

Failed conditions
8.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 348 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZ6PyICYIaTFPUKdiAFn&open=AZ6PyICYIaTFPUKdiAFn&pullRequest=189

Check warning on line 1179 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof HasEnabled hasenabled' 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZ6PyICYIaTFPUKdiAFp&open=AZ6PyICYIaTFPUKdiAFp&pullRequest=189

Check failure on line 85 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "com.flowingcode.vaadin.addons.gridexporter.ConcurrentOperationBase" for "MIN_COST". 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZ6PBnIVvVo3O9WvvAb1&open=AZ6PBnIVvVo3O9WvvAb1&pullRequest=189

Check warning on line 1126 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZ6PyICYIaTFPUKdiAFo&open=AZ6PyICYIaTFPUKdiAFo&pullRequest=189

Check failure on line 82 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "com.flowingcode.vaadin.addons.gridexporter.ConcurrentOperationBase" for "MAX_COST". 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZ6PBnIVvVo3O9WvvAb0&open=AZ6PBnIVvVo3O9WvvAb0&pullRequest=189

Check failure on line 1147 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZ6PBnIVvVo3O9WvvAb2&open=AZ6PBnIVvVo3O9WvvAb2&pullRequest=189
View more details on SonarQubeCloud