Skip to content

Add read-only Desktop workspace discovery for Floorp iOS - #10

Merged
Ryosuke-Asano merged 2 commits into
floorp-iosfrom
codex/workspace-discovery-rust
Oct 26, 2026
Merged

Ryosuke-Asano merged 2 commits into
floorp-iosfrom
codex/workspace-discovery-rust

Conversation

@Ryosuke-Asano

Copy link
Copy Markdown
Member

Add the read-only floorp-workspaces v1 engine needed for Floorp iOS to list Desktop workspaces and open independent local copies. No Workspace upload, remote deletion, or local tab reconciliation is introduced.

The engine validates the pinned Desktop wire format, stages a complete paginated collection before committing its cursor, rejects unsupported remote metadata before destructive Sync setup, and withdraws copy eligibility across account or association resets. Negative eligibility is journaled across failed cache writes and restart. The iOS megazord exports the store and a lightweight copy eligibility API; release verification checks the generated binding and every device/simulator slice.

Validation: Workspace 21, sync15 90, prefs/Notes 25, Sync Manager 6 tests; distribution automation 46 tests and cargo formatting passed locally. The previous implementation also passed a real arm64 simulator native binding smoke and 123 iOS integration tests. Required hosted CI builds the full candidate with pinned Xcode 26.3 before release.

Pull Request checklist

  • Breaking changes: New APIs are additive; existing engines keep their defaults. The matching Floorp iOS consumer implementation is prepared in the dedicated workspace.
  • Quality: Focused local tests and formatting passed; required hosted native and iOS artifact checks must pass before merge.
  • Tests: Includes Desktop-generated fixtures, paging/version/read-only tests, durable invalidation tests, and release/CI contract coverage.
  • Changelog: Floorp-specific behavior and compatibility are documented in components/floorp-workspaces-sync/README.md; this does not change Mozilla's upstream product changelog.
  • Dependencies: Uses existing workspace dependencies; Cargo.lock records the new internal crate and registry integration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T06:28:41.810378Z ff169a7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Ryosuke-Asano
Ryosuke-Asano merged commit a859c78 into floorp-ios Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant