Repository navigation
Add read-only Desktop workspace discovery for Floorp iOS - #10
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the read-only
floorp-workspacesv1 engine needed for Floorp iOS to list Desktop workspaces and open independent local copies. No Workspace upload, remote deletion, or local tab reconciliation is introduced.The engine validates the pinned Desktop wire format, stages a complete paginated collection before committing its cursor, rejects unsupported remote metadata before destructive Sync setup, and withdraws copy eligibility across account or association resets. Negative eligibility is journaled across failed cache writes and restart. The iOS megazord exports the store and a lightweight copy eligibility API; release verification checks the generated binding and every device/simulator slice.
Validation: Workspace 21, sync15 90, prefs/Notes 25, Sync Manager 6 tests; distribution automation 46 tests and cargo formatting passed locally. The previous implementation also passed a real arm64 simulator native binding smoke and 123 iOS integration tests. Required hosted CI builds the full candidate with pinned Xcode 26.3 before release.
Pull Request checklist
components/floorp-workspaces-sync/README.md; this does not change Mozilla's upstream product changelog.