Repository navigation
Characters: a caption for each picture, up to 24 pictures and an editable description - #564
Open
albertleal wants to merge 1 commit into
Open
albertleal wants to merge 1 commit into
albertleal wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change / 改动
I like the character library in the latest versions. Until now, though, I still had to write into every prompt what each reference picture shows (a tattoo on the back, a scar, a detail of the outfit…), because a card only carried its description plus a sheet and a face. This is a small enhancement for that need. Merge it if it fits, or take it as inspiration and build it your own way. I know CONTRIBUTING asks for an issue first. I'm happy to open one, or you can close this and keep it as a feature request.
Character cards
subject_definitions: <Subject 1> is Pepa: a young courier. <Picture 1> to <Picture 4> show its appearance; <Picture 3> shows the rabbit tattoo on her neck.The wording is the same in
drama.subject_definitions(Agent) andsubjectDefinitions(web/cast_mention.js, Studio @-mentions). If the prompt is over the limit, captions are shortened along with descriptions (with_cast).MAX_CAST_IMAGESandMAX_CAST_CAPTIONinagent/schema.py, mirrored inweb/cast_library.js. The sheet still uses at most 6 views, and candidates stay at 6.images[].captionon create/update and in the card view.""removes a caption; leaving the field out keeps it. The agent can't change a caption the user set (samechanged_by_userrule as for pictures). The agent guide and schema descriptions are updated.Character dialog
What a shot carries
person_pictures,cast_references) and to Studio mentions (cardPictures).revision. After a card is edited, that character's rows in the media list are rebuilt in place (pictures, captions, description). The @ handle stays the same and switched-off pictures stay off (staleCast,withCurrentCard).Studio
Open points
drama.pysays was chosen after your reference tests, and it adds reference tokens to each shot. I have no before/after speed or VRAM measurements.continuation.pick_pictureskeeps the first 3 rows, so a card with more than 3 pictures loses its stand-in, which is now last. Keeping the first two plus the last would fix this.tests/fixtures/subject_definitions.jsonisn't in the public repo and needs a case with captions.web/tutorial_book_content.js) and its screenshot, the version and the release notes.中文简述:角色卡的每张图片可加一句说明(如“背上的龙纹身”),生成时以
<Picture N> shows …写进提示词;每个角色最多 24 张图片;角色窗口可编辑描述;新镜头带上角色的全部图片(代表图放最后;超出 32 个参考时保留前几张和代表图),接续镜头不变;已 @ 的角色在角色卡修改后自动更新;创作面板新增“完整提示词”查看。Validation / 验证
node --checkon everyweb/*.js,node scripts/test_freevideo_entry.mjsandnode scripts/test_prompt_guide.mjs.scripts/test_freevideo_entry.mjs: after its card is edited, a mentioned character gets every picture with its caption and the new description. A switched-off picture stays off, and an unchanged card rewrites nothing.<Picture N> shows …matches its row in the media list.AI disclosure: written with help from GitHub Copilot. I reviewed and ran every change.