Applications: Consolidate common files between Spark.Web.* projects - #1388
Merged
Merged
Conversation
kennethmyhra
force-pushed
the
consolidate-web-app
branch
from
August 9, 2026 17:30
640c82e to
a36b989
Compare
losolio
approved these changes
Aug 9, 2026
losolio
left a comment
losolio
left a comment
Collaborator
There was a problem hiding this comment.
Nice work! I think maybe the npm install now installs 4 times in parallell, could be a bit error prone in the future.
We could also use the opportunity to delete some old razor views:
Views/_ViewStart.cshtml and the files in Views/Shared/
I think also libman.json could be deleted
kennethmyhra
force-pushed
the
consolidate-web-app
branch
from
August 9, 2026 18:34
a36b989 to
e8d76e9
Compare
kennethmyhra
force-pushed
the
consolidate-web-app
branch
from
August 9, 2026 18:43
e8d76e9 to
dfc46fd
Compare
Collaborator
Author
|
We'll decide on the npm install in the future, if it causes any problems. For now this is the simplest approach, I can think of, without making the project harder to run from an IDE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.