Skip to content

fix: stream disconnect#150

Merged
noahpodgurski merged 5 commits into
mainfrom
stream-disconnect-fix
May 12, 2026
Merged

fix: stream disconnect#150
noahpodgurski merged 5 commits into
mainfrom
stream-disconnect-fix

Conversation

@noahpodgurski
Copy link
Copy Markdown
Collaborator

What's new

  • Fix stream disconnect issue by aborting upstream reads cleanly on client disconnect and avoiding spurious ReadError empty-response failures, especially before the first token.

@noahpodgurski noahpodgurski requested a review from a team as a code owner May 11, 2026 16:18
Comment thread src/mlpa/core/completions.py Outdated
Copy link
Copy Markdown
Collaborator

@subpath subpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ❤️
I think in the tests I've made for stream abortion I should have use httpx.ReadError instead of the RuntimeError

@noahpodgurski noahpodgurski merged commit 81ca7c9 into main May 12, 2026
1 check passed
@noahpodgurski noahpodgurski deleted the stream-disconnect-fix branch May 12, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants