Skip to content

ci(dco): require a sign-off on every commit - #680

Open
BryanFRD wants to merge 1 commit into
mainfrom
ci/dco
Open

BryanFRD wants to merge 1 commit into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct: it calls the org's reusable DCO workflow, which is pinned by SHA and runs with contents: read on pull_request, not pull_request_target. That also suits fork PRs. The PR's only commit is signed off.

Nit: the edited type re-runs the check whenever the title or body changes, and those edits never change the commits. You can drop it unless you need it to re-trigger a stuck check by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant