Repository navigation
fix(grants): stop serving folders granted by a disabled account - #386
Conversation
There was a problem hiding this comment.
The owner filter now covers every read path that uses grantee_email (received, mounts, mount, search). mount still checks for a trashed node through live_node, so leaving out deleted_at on its new nodes join is fine. The test follows the same shape as the existing trashed-folder test.
Nit: the test never calls the received listing endpoint, so that query change has no test coverage.
Separately, the sign-off check fails on this head commit. That is a commit metadata problem, not a code one, but it will probably need fixing before merge.
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
eb40473 to
4cc9944
Compare
There was a problem hiding this comment.
Re-approving on the rebased head. Since f1b1c3b, api/src/grants.rs and api/src/search.rs are unchanged. The only code change is in the test: the Shared with me root listing now expects an empty shelf instead of a 404. That is correct, because the root always exists and the existing shelf test at line 793 asserts it the same way. All three commits now carry a sign-off.
Join the owner in
grants::mount,grants::mounts,grants::receivedand the search CTE and drop grants whose owner hasdisabled_atset, matching what public links already do.Test added in
api/tests/grants.rs. It needsDATABASE_URL, so it was not run locally (the harness skips without it); CI runs it.Closes #373