Skip to content

ci(dco): require a sign-off on every commit - #472

Open
BryanFRD wants to merge 1 commit into
mainfrom
ci/dco
Open

BryanFRD wants to merge 1 commit into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The workflow calls the org's reusable DCO workflow pinned to a SHA, with contents: read, and uses pull_request rather than _target, so fork code never runs with elevated rights. Keeping edited in the types list is right: a base-branch change fires that event and shifts the commit range being checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant