Repository navigation
ci(release): disable the setup-node cache in the npm publish job - #471
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ref: ${{ inputs.tag || github.ref_name }} | ||
| - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6 | ||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7 # zizmor: ignore[cache-poisoning] | ||
| - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7 |
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks right. setup-node turns on its package-manager cache by default when package.json has a packageManager field. Setting package-manager-cache: false switches it off, so the publish job (which has id-token: write) can't restore a poisoned cache. That's a better fix than the zizmor: ignore[cache-poisoning] it replaces. No cache: input is set anywhere else in the job, so nothing turns the cache back on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
package-manager-cache: falseon setup-node inpublish-npmand drops the zizmor cache-poisoning ignore, so the provenance-signed publish never restores a shared pnpm store.Closes #465