Skip to content

ci(dco): require a sign-off on every commit - #698

Open
BryanFRD wants to merge 1 commit into
mainfrom
ci/dco
Open

BryanFRD wants to merge 1 commit into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calls the org reusable DCO workflow pinned by SHA, with least-privilege permissions. The reusable job checks origin/<base>..head with no merges, and this PR's own commit is signed off. Nothing blocking.

Nit: edited only fires on title/body/base changes. Title and body can't change the commit list, so those reruns do nothing. Only a base-branch change matters here. Keeping edited is harmless (the reusable workflow's concurrency group cancels overlapping runs), but [opened, synchronize, reopened] would be enough unless you want base retargets covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant