Skip to content

ci(dco): require a sign-off on every commit - #370

Open
BryanFRD wants to merge 1 commit into
mainfrom
ci/dco
Open

BryanFRD wants to merge 1 commit into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. This follows the repo's thin-caller pattern (the same setup as pr-title.yml): it calls the shared reusable workflow pinned to a SHA, with least-privilege contents: read. Using pull_request rather than _target is the right choice for a check that only reads git history. Keeping edited in the trigger list makes sense because changing the base branch changes the commit range being checked. The PR's own commit is signed off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant