Repository navigation
fix(oauth): expire the cached oidc jwks after one hour - #369
Merged
Merged
Conversation
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks correct. The max-age check runs before both the kid hit and the JWKS_MIN_REFRESH grace path, so a stale set can't be served, and keys_for refetches and resets fetched_at as before. The test covers both sides of the boundary for Some(kid) and None.
Expected side effect: once the hour is up, a failed JWKS fetch now fails login instead of falling back to the stale set. That fits what this PR is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JWKS cache was served forever while it contained the token's kid, so a key dropped by the IdP kept verifying until restart. The cache now expires after 1 h; the 60 s minimum between refreshes for unknown kids is unchanged.
Closes #349