Repository navigation
chore(cache): replace rustls-pemfile with rustls-pki-types - #343
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 16, 2026 19:08
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
The migration is correct. pem_slice_iter skips non-certificate sections the same way rustls_pemfile::certs did, the empty-bundle and corrupt-bundle paths keep their error messages, and the new tests cover all three cases. The advisory ignore can go. One nit is inline (dependency source / version floor), nothing blocking.
There was a problem hiding this comment.
The nit on the direct rustls-pki-types dependency is fixed in 27db7c5, and that commit introduces nothing new. No findings remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses the Valkey CA bundle with
CertificateDer::pem_slice_iterinstead of the unmaintainedrustls-pemfile, and drops the RUSTSEC-2025-0134 ignore fromdeny.toml(cargo deny check advisoriespasses without it).Adds tests for
rustls_config_with_ca: valid CA, empty bundle, corrupt certificate.Refs #260. The issue stays open: the
rsaadvisory (RUSTSEC-2023-0071) is still ignored.