Skip to content

ci(dco): require a sign-off on every commit - #329

Merged
BryanFRD merged 1 commit into
mainfrom
ci/dco
Oct 25, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right: uses the org's pinned reusable DCO workflow, pull_request (not _target) with read-only contents, and the commit here is signed off.

Nit: edited only fires on title/body/base edits, which can't change commit trailers, so it just re-runs the check for nothing. Base-branch changes are the one case it covers; if you want to keep that, leave it as is.

@BryanFRD
BryanFRD merged commit 7a07ebb into main Oct 25, 2026
20 checks passed
@BryanFRD
BryanFRD deleted the ci/dco branch October 25, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant