Repository navigation
fix(mcp): align cycle and milestone tools with the api contract - #16
Merged
Merged
Conversation
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks correct. Nothing in prompts/resources still references the removed get_cycle/get_milestone or the old milestone field names. The tests cover the new contract. I could not check the API contract itself because the server is not in this repo, so I took the PR's description of the routes and fields as given. One nit inline about datetime offsets.
There was a problem hiding this comment.
The offset nit is fixed in 913a0b5 and nothing new came up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
get_cycleandget_milestone: the API has no GET on those paths (always 405). Re-add if the handlers land in the API.create_cycle/update_cycle: dates validated as ISO datetimes;statusremoved fromupdate_cycle(derived from dates);created_byadded toCycle.description/due_atrenamed tosummary/target_date; status enum is nowplanned|in_progress|shipped|canceled.Not done: the contract/smoke check against the real API suggested in the issue.