Skip to content

ci(dco): require a sign-off on every commit - #1350

Merged
BryanFRD merged 2 commits into
mainfrom
ci/dco
Oct 25, 2026
Merged

BryanFRD merged 2 commits into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The reusable workflow at the pinned SHA only needs contents: read. It checks out with persist-credentials: false and uses plain pull_request, so fork PRs are safe. One nit inline.

Comment thread .github/workflows/dco.yml Outdated
Co-authored-by: ferrfleet-interne[bot] <342363332+ferrfleet-interne[bot]@users.noreply.github.com>
@BryanFRD
BryanFRD enabled auto-merge (squash) October 25, 2026 11:18

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edited nit is fixed in 42ed62c.

Blocking: 42ed62c ("Update .github/workflows/dco.yml") was made by applying the suggestion in the GitHub UI, and it has no Signed-off-by: trailer. The workflow this PR adds now fails on its own PR (sign-off / sign-off is red). To fix it, run git rebase --signoff origin/main and push with --force-with-lease, or squash both commits into one signed-off commit.

@BryanFRD
BryanFRD merged commit 48ea2ae into main Oct 25, 2026
31 of 32 checks passed
@BryanFRD
BryanFRD deleted the ci/dco branch October 25, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant