Repository navigation
fix(release): resume a release interrupted after the release commit - #1349
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
One blocking finding: a resumed release skips registry publishers and post-publish hooks, because hook_contexts is never rebuilt, and then reports success. One nit on which plan wins when bumps are detected again. Persisting the checkpoint and floating tags looks correct otherwise.
Contributor
There was a problem hiding this comment.
Both earlier findings are fixed in 7536b33, and their threads are resolved.
Nit: resumed_hook_contexts sets channel: None, but package.rs:253 fills it from the prerelease context. So a resumed prerelease passes hooks and publishers no channel. The checkpoint doesn't record the channel, so fixing this would mean persisting it or re-deriving it from the branch config. That's optional.
ferrflow Bot
added a commit
that referenced
this pull request
Oct 25, 2026
## [7.33.4] - 2026-10-25 ### Bug Fixes - fix(release): resume a release interrupted after the release commit (#1349)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release that failed at push left the release commit, tags and a checkpoint local only. The checkpoint was pinned to the pre-commit HEAD, so later runs never matched it and reported nothing to release.
Closes #1341