Repository navigation
fix(cascade): keep dependents of a prerelease run on the prerelease channel - #1348
Merged
Merged
Conversation
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cascaded dependents now go through the same with_prerelease_suffix as directly planned packages, and is_prerelease reaches the version hook, release JSON, check output and planned tag. The test covers the counter continuing from an existing -beta.1 tag. One nit inline, nothing blocking.
Contributor
There was a problem hiding this comment.
ee6da72 drops the duplicated channel field. Pass::channel() now reads it from prerelease_ctx, so the two can no longer disagree. Nothing new to flag.
BryanFRD
enabled auto-merge (squash)
October 25, 2026 10:19
ferrflow Bot
added a commit
that referenced
this pull request
Oct 25, 2026
## [7.33.3] - 2026-10-25 ### Bug Fixes - fix(cascade): keep dependents of a prerelease run on the prerelease channel (#1348)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cascade computed dependents' versions without the prerelease suffix and marked them stable, so
--channel betareleased stable dependents and moved their floating tags.The run's prerelease context is now passed into the cascade,
with_prerelease_suffixis applied to cascaded versions, andis_prereleaseis set on the tag, JSON output and release hook candidate.Closes #1340