Skip to content

ci(dco): require a sign-off on every commit - #12

Open
BryanFRD wants to merge 2 commits into
mainfrom
ci/dco
Open

BryanFRD wants to merge 2 commits into
mainfrom
ci/dco

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Adds the shared DCO check (FerrLabs/.github reusable-dco). Every commit of a PR needs a Signed-off-by line; fix with git rebase --signoff origin/main. Renovate signs off through the shared preset.

Signed-off-by: BryanFRD <bryanferrando59@gmail.com>

@ferrfleet-interne ferrfleet-interne Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses the org's reusable DCO workflow, pinned to a SHA the way pr-title.yml does, and keeps contents: read. Because it uses pull_request and not _target, fork code never runs with secrets. Nothing blocking.

Nit: the edited event only fires when someone edits the PR title, body or base branch. A title or body edit leaves the commits unchanged, so the check runs again for nothing. A base-branch change is the exception, since it can change the commit range. Dropping edited (types: [opened, synchronize, reopened]) is fine unless retargeting PRs is common here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant