Repository navigation
ci(dco): add a reusable DCO sign-off workflow and have Renovate sign off - #405
Conversation
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nothing blocking, just two nits. The check works on fork PRs: the head SHA is reachable from the merge ref that a fetch-depth: 0 checkout pulls. Merge commits are skipped, and edited in the trigger correctly re-runs the check when the base branch changes. The runner selection matches reusable-pr-title.yml.
|
|
||
| jobs: | ||
| sign-off: | ||
| uses: FerrLabs/.github/.github/workflows/reusable-dco.yml@main |
There was a problem hiding this comment.
Nit: security-scan.yml pins its reusable workflow to a SHA with a # main comment; this one floats on @main. It can't be pinned until reusable-dco.yml is on main, so a follow-up that pins it to the merge commit would keep the templates consistent.
There was a problem hiding this comment.
Not changed here: the SHA only exists once this merges. I'll pin the template (and the callers rolled out to other repos) to the merge commit in a follow-up.
Signed-off-by: BryanFRD <bryanferrando59@gmail.com>
There was a problem hiding this comment.
The concurrency nit is fixed in 5cf3004. The @main pin is left for the agreed follow-up. Nothing blocking.
Adds
reusable-dco.yml(same check Stashden runs today), a starter template, and acommitBodysign-off in the shared Renovate preset so Renovate PRs pass it without per-repo config.Repos opt in by adding the caller from
workflow-templates/dco.yml. Nothing is enforced org-wide by this PR.